Skip to content

#137 — Create Comprehensive Tests for Date Range Filtering#154

Closed
Anuoluwapo25 wants to merge 5 commits intoShadeProtocol:mainfrom
Anuoluwapo25:date-range-filtering
Closed

#137 — Create Comprehensive Tests for Date Range Filtering#154
Anuoluwapo25 wants to merge 5 commits intoShadeProtocol:mainfrom
Anuoluwapo25:date-range-filtering

Conversation

@Anuoluwapo25
Copy link

Description

This PR introduces comprehensive test coverage for invoice date range filtering in the ShadeProtocol repository.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Test improvements
  • Other (please describe):

Related Issues

Fixes #137

Changes Made

Created multiple invoices with different ledger timestamps

Simulated varying time intervals to validate filter logic

Added test cases for:

Exact boundary matches

Ranges containing no invoices

Single-invoice range matches

Overlapping and edge timestamp cases

Ensured deterministic ledger timestamp setup for reproducibility

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • All existing tests pass locally
  • I have tested this manually

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

closes #137

@drips-wave
Copy link

drips-wave bot commented Mar 24, 2026

@Anuoluwapo25 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@codebestia codebestia closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Comprehensive Tests for Date Range Filtering

2 participants